-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExplicitImports.jl test #1875
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Only one place where imho a second set of eyes necessary, but then it can imho be merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 96.30% 89.48% -6.82%
==========================================
Files 439 439
Lines 35749 35738 -11
==========================================
- Hits 34428 31979 -2449
- Misses 1321 3759 +2438
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov seems to be down for some reason. And then there are the known t8code issues again. |
Closing and reopening this PR to trigger CI again (I don't have the rights to rerun the jobs without closing and opening). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov is down again... |
This adds a test using ExplicitImports.jl to check whether we have unused explicit imports or any implicit imports. It also includes the necessary changes to make the test pass.